HW1 #10
Open
HW1 #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
June 28, 2019 11:03
aleksandrbelik
requested changes
Jul 11, 2019
| .weekday { | ||
| border-bottom: 2px solid #8E4140; | ||
| padding-top: 15px; | ||
| padding-bottom: 10px; |
There was a problem hiding this comment.
@Zorin-Alex Please look at padding property
You can set it in one line padding: 15px 0 10px 0
|
|
||
| .dayWeatherLogo { | ||
| padding-left: 15px; | ||
| padding-right: 15px; |
There was a problem hiding this comment.
@Zorin-Alex Please look at padding property
You can set in one line padding: 0 15px
| <body> | ||
| <article class="weatherWidget"> | ||
| <div class="location"> | ||
| <div class="weatherTypeLogo"><img src="img/weather/sunny-big.png" width="50%"></div> |
There was a problem hiding this comment.
@Zorin-Alex It's better to move width of image to css
| <div class="weekdayInformation"><p class="weekday">Fri</p><p class="dayTimeTemp">22 °C</p><p class="nightTimeTemp">20 °C</p></div> | ||
| </div> | ||
| <div class="day"> | ||
| <img class="dayWeatherLogo" src="img/weather/cloudy.png" width="70%"> |
There was a problem hiding this comment.
@Zorin-Alex same case with width for the . dayWeatherLogo. It's much more better to set width property in css
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.