homework_1 #9
homework_1 #9
Conversation
-add items for widget -add markup
| @@ -0,0 +1,104 @@ | |||
| body{ | |||
There was a problem hiding this comment.
You should add space after selector, same for all other cases
body {
| </head> | ||
| <body> | ||
| <div class="main"> | ||
| <img src="Paris.png"> |
There was a problem hiding this comment.
Images should have alt attribute, either empty alt="" or with picture described in two words
|
|
||
| <div class="crt"> | ||
| <div class="degrees"> | ||
| <img src="degrees/12.png"> |
There was a problem hiding this comment.
Please, use plain text instead of images, same for all other cases
| </div> | ||
|
|
||
| <div class="divider"> | ||
| <img src="divider.png"> |
| <span class="in"><img src="Thursday/Thursday.png"></span> | ||
| <span class="in"><img src="Thursday/Overcast.png"></span> | ||
| <span class="in"><img src="Thursday/18 o.png"></span> | ||
| </div> |
There was a problem hiding this comment.
You have a lot of similar html tags, <ul> would be better in this case
You should use more semantic tags
| padding-left: 40px; | ||
| padding-right: 50px; | ||
| margin-top: 80px; | ||
| display: inline-flex; |
There was a problem hiding this comment.
Keep in mind order of properties, group them by type
1 - layout (position, display)
2 - anything related to box model (width/height/margin/padding)
3 - styling for element (color, background, box-shadow)
4 - anything related to font
5 - other stuff, it also includes overflow, z-index
|
|
||
| } | ||
|
|
||
| .crt{ |
There was a problem hiding this comment.
More convenient names, I would use something like info in this case
2 participants
-add items for widget
-add markup