-
Notifications
You must be signed in to change notification settings - Fork 12
homework_1 #9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
homework_1 #9
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,104 @@ | ||
| body{ | ||
| background-image: url('bg.png'); | ||
| background-size: cover; | ||
| } | ||
|
|
||
| .main{ | ||
| padding-left: 50px; | ||
| padding-top: 60px; | ||
| } | ||
|
|
||
| .date{ | ||
| margin-top: -365px; | ||
| margin-left: 414px; | ||
| display: flex; | ||
|
|
||
| } | ||
|
|
||
| .crt{ | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. More convenient names, I would use something like |
||
| margin-top: -35px; | ||
| margin-left: 530px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| } | ||
|
|
||
| .degrees{ | ||
| display: inline-flex; | ||
| } | ||
|
|
||
| .degree{ | ||
| padding-left: 5px; | ||
| } | ||
|
|
||
| .location{ | ||
| padding-top: 15px; | ||
| padding-left: -1px; | ||
| } | ||
|
|
||
| .wind{ | ||
| padding-top: 20px; | ||
| display: inline-flex; | ||
| } | ||
|
|
||
| .wind_picture{ | ||
| padding: 3px; | ||
| } | ||
|
|
||
| .weather{ | ||
| padding-left: 40px; | ||
| padding-right: 50px; | ||
| margin-top: 80px; | ||
| display: inline-flex; | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Keep in mind order of properties, group them by type |
||
| width: 750px; | ||
| justify-content: space-around; | ||
|
|
||
| } | ||
|
|
||
| .pointer{ | ||
| align-self: center; | ||
| padding-top: 5px; | ||
| } | ||
|
|
||
| .back{ | ||
| padding-left: 60px; | ||
| } | ||
|
|
||
| .next{ | ||
| padding-right: 100px; | ||
| } | ||
|
|
||
| .divider{ | ||
| padding-left: -15px; | ||
| padding-top: 10px; | ||
| align-self: center; | ||
| } | ||
|
|
||
| .days{ | ||
| margin-top: 0px; | ||
| margin-left: 10px; | ||
|
|
||
| /*align-items: top;*/ | ||
| display: flex; | ||
| flex-direction: row; | ||
| } | ||
|
|
||
| .day{ | ||
| padding-top: 10px; | ||
| padding-bottom: 10px; | ||
| padding-right: 5px; | ||
| padding-left: 5px; | ||
| display: flex; | ||
| flex-direction: column; | ||
| align-items: center; | ||
| } | ||
|
|
||
| .in{ | ||
| padding-top: 5px; | ||
| padding-left: 30px; | ||
| padding-right: 20px; | ||
| } | ||
|
|
||
| .tuesday{ | ||
| padding-top: 15px; | ||
| } | ||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,82 @@ | ||
| <!DOCTYPE html> | ||
| <html> | ||
| <head> | ||
| <title>Paris</title> | ||
| <link href="styles.css" rel="stylesheet"> | ||
| </head> | ||
| <body> | ||
| <div class="main"> | ||
| <img src="Paris.png"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Images should have alt attribute, either empty |
||
| </div> | ||
|
|
||
| <div class="info"> | ||
| <div class="date"> | ||
| <img src="Friday August, 23rd.png"> | ||
| </div> | ||
|
|
||
| <div class="crt"> | ||
| <div class="degrees"> | ||
| <img src="degrees/12.png"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Please, use plain text instead of images, same for all other cases |
||
| <span class="degree"><img src="degrees/o.png"></span> | ||
| </div> | ||
| <div class="location"> | ||
| <img src="Paris, France.png"> | ||
| </div> | ||
| <div class="wind"> | ||
| <span class="wind_picture"><img src="wind/Wind.png"></span> | ||
| <span class="wind_picture"><img src="wind/14 mph.png"></span> | ||
| </div> | ||
| </div> | ||
| </div> | ||
|
|
||
| <div class="weather"> | ||
|
|
||
| <div class="pointer back"> | ||
| <img src="Back.png"> | ||
| </div> | ||
|
|
||
| <div class="days"> | ||
| <div class="day"> | ||
| <span class="in"><img src="Monday/Monday.png"></span> | ||
| <span class="in"><img src="Monday/Rain.png"></span> | ||
| <span class="in"><img src="Monday/10 o.png"></span> | ||
| </div> | ||
|
|
||
| <div class="divider"> | ||
| <img src="divider.png"> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Why not border-right/left? |
||
| </div> | ||
|
|
||
| <div class="day"> | ||
| <span class="in"><img src="Tuesday/Tuesday.png"></span> | ||
| <span class="in"><img src="Tuesday/Cloudy.png"></span> | ||
| <span class="in tuesday"><img src="Tuesday/15 o.png"></span> | ||
| </div> | ||
|
|
||
| <div class="divider"> | ||
| <img src="divider.png"> | ||
| </div> | ||
|
|
||
| <div class="day"> | ||
| <span class="in"><img src="Wednesday/Wednesday.png"></span> | ||
| <span class="in"><img src="Wednesday/Sunny.png"></span> | ||
| <span class="in"><img src="Wednesday/23 o.png"></span> | ||
| </div> | ||
|
|
||
| <div class="divider"> | ||
| <img src="divider.png"> | ||
| </div> | ||
|
|
||
| <div class="day"> | ||
| <span class="in"><img src="Thursday/Thursday.png"></span> | ||
| <span class="in"><img src="Thursday/Overcast.png"></span> | ||
| <span class="in"><img src="Thursday/18 o.png"></span> | ||
| </div> | ||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. You have a lot of similar html tags, |
||
| </div> | ||
|
|
||
| <div class="pointer next"> | ||
| <img src="Next.png"> | ||
| </div> | ||
| </div> | ||
|
|
||
| </body> | ||
| </html> | ||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You should add space after selector, same for all other cases
body {