Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Binary file added Natasha Yakovleva/widget/Back.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Friday August, 23rd.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Monday/10 o.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Monday/Monday.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Monday/Rain.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Next.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Paris, France.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Paris.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Paris.psd
Binary file not shown.
Binary file added Natasha Yakovleva/widget/Paris_main.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Thursday/18 o.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Thursday/Overcast.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Thursday/Thursday.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Tuesday/15 o.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Tuesday/Cloudy.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Tuesday/Tuesday.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Wednesday/23 o.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Wednesday/Sunny.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/Wednesday/Wednesday.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/bg.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/degrees/12.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added Natasha Yakovleva/widget/degrees/o.png
Binary file added Natasha Yakovleva/widget/divider.png
104 changes: 104 additions & 0 deletions Natasha Yakovleva/widget/styles.css
Original file line number Diff line number Diff line change
@@ -0,0 +1,104 @@
body{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should add space after selector, same for all other cases
body {

background-image: url('bg.png');
background-size: cover;
}

.main{
padding-left: 50px;
padding-top: 60px;
}

.date{
margin-top: -365px;
margin-left: 414px;
display: flex;

}

.crt{
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

More convenient names, I would use something like info in this case

margin-top: -35px;
margin-left: 530px;
display: flex;
flex-direction: column;
}

.degrees{
display: inline-flex;
}

.degree{
padding-left: 5px;
}

.location{
padding-top: 15px;
padding-left: -1px;
}

.wind{
padding-top: 20px;
display: inline-flex;
}

.wind_picture{
padding: 3px;
}

.weather{
padding-left: 40px;
padding-right: 50px;
margin-top: 80px;
display: inline-flex;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Keep in mind order of properties, group them by type
1 - layout (position, display)
2 - anything related to box model (width/height/margin/padding)
3 - styling for element (color, background, box-shadow)
4 - anything related to font
5 - other stuff, it also includes overflow, z-index

width: 750px;
justify-content: space-around;

}

.pointer{
align-self: center;
padding-top: 5px;
}

.back{
padding-left: 60px;
}

.next{
padding-right: 100px;
}

.divider{
padding-left: -15px;
padding-top: 10px;
align-self: center;
}

.days{
margin-top: 0px;
margin-left: 10px;

/*align-items: top;*/
display: flex;
flex-direction: row;
}

.day{
padding-top: 10px;
padding-bottom: 10px;
padding-right: 5px;
padding-left: 5px;
display: flex;
flex-direction: column;
align-items: center;
}

.in{
padding-top: 5px;
padding-left: 30px;
padding-right: 20px;
}

.tuesday{
padding-top: 15px;
}

82 changes: 82 additions & 0 deletions Natasha Yakovleva/widget/widget.html
Original file line number Diff line number Diff line change
@@ -0,0 +1,82 @@
<!DOCTYPE html>
<html>
<head>
<title>Paris</title>
<link href="styles.css" rel="stylesheet">
</head>
<body>
<div class="main">
<img src="Paris.png">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Images should have alt attribute, either empty alt="" or with picture described in two words

</div>

<div class="info">
<div class="date">
<img src="Friday August, 23rd.png">
</div>

<div class="crt">
<div class="degrees">
<img src="degrees/12.png">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please, use plain text instead of images, same for all other cases

<span class="degree"><img src="degrees/o.png"></span>
</div>
<div class="location">
<img src="Paris, France.png">
</div>
<div class="wind">
<span class="wind_picture"><img src="wind/Wind.png"></span>
<span class="wind_picture"><img src="wind/14 mph.png"></span>
</div>
</div>
</div>

<div class="weather">

<div class="pointer back">
<img src="Back.png">
</div>

<div class="days">
<div class="day">
<span class="in"><img src="Monday/Monday.png"></span>
<span class="in"><img src="Monday/Rain.png"></span>
<span class="in"><img src="Monday/10 o.png"></span>
</div>

<div class="divider">
<img src="divider.png">
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not border-right/left?

</div>

<div class="day">
<span class="in"><img src="Tuesday/Tuesday.png"></span>
<span class="in"><img src="Tuesday/Cloudy.png"></span>
<span class="in tuesday"><img src="Tuesday/15 o.png"></span>
</div>

<div class="divider">
<img src="divider.png">
</div>

<div class="day">
<span class="in"><img src="Wednesday/Wednesday.png"></span>
<span class="in"><img src="Wednesday/Sunny.png"></span>
<span class="in"><img src="Wednesday/23 o.png"></span>
</div>

<div class="divider">
<img src="divider.png">
</div>

<div class="day">
<span class="in"><img src="Thursday/Thursday.png"></span>
<span class="in"><img src="Thursday/Overcast.png"></span>
<span class="in"><img src="Thursday/18 o.png"></span>
</div>
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You have a lot of similar html tags, <ul> would be better in this case
You should use more semantic tags

</div>

<div class="pointer next">
<img src="Next.png">
</div>
</div>

</body>
</html>
Binary file added Natasha Yakovleva/widget/wind/14 mph.png
Binary file added Natasha Yakovleva/widget/wind/Wind.png