Skip to content

[Dropdown]: fix hide dropdown body on mobile after opening keyboard #363

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AlekseyManetov merged 1 commit into from
Dec 29, 2021
Merged

[Dropdown]: fix hide dropdown body on mobile after opening keyboard #363

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion uui-components/src/overlays/Dropdown.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,8 @@ export interface DropdownProps extends Partial<IEditable<boolean>> {

portalTarget?: HTMLElement;
boundaryElement?: Boundary;

closeBodyOnTogglerHidden?: boolean; // default: true; Set false if you do not want to hide the dropdown body in case Toggler is out of the viewport
}

export class Dropdown extends React.Component<DropdownProps, DropdownState> {
Expand Down Expand Up @@ -191,7 +193,7 @@ export class Dropdown extends React.Component<DropdownProps, DropdownState> {
}
};

if (isReferenceHidden && (this.state.opened || this.props.value)) {
if (isReferenceHidden && this.props.closeBodyOnTogglerHidden !== false && (this.state.opened || this.props.value)) {
// Yes, we know that it's hack and we can perform setState in render, but we don't have other way to do it in this case
setTimeout(() => { this.handleOpenedChange(false); }, 0);
return null;
Expand Down
1 change: 1 addition & 0 deletions uui-components/src/pickers/PickerInputBase.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -281,6 +281,7 @@ export abstract class PickerInputBase<TItem, TId, TProps> extends PickerBase<TIt
onValueChange={ !this.props.isDisabled && this.toggleBodyOpening }
placement={ this.props.dropdownPlacement }
modifiers={ this.popperModifiers }
closeBodyOnTogglerHidden={ !isMobile() }
/>
);
}
Expand Down