feat: expose missing typed model/features listing fields #112#113
Merged
Conversation
Add typed Pydantic fields for model/features listing fields that DIAL Core returns but the client only accepted via extra-field passthrough: - ModelInfo.embedding_dimensions - Features.chat_completion, Features.responses_api - Features.reasoning_efforts (supersedes reasoning_efforts_supported) - Features.max_tokens_supported, max_completion_tokens_supported, custom_temperature_supported (pre-existing drift) Document the new fields in the README sample responses.
ypldan
changed the title
ypldan
changed the title
adubovik
approved these changes
Jun 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Applicable issues
Description of changes
Expose listing fields that DIAL Core returns as first-class typed Pydantic fields. They previously only passed through via
extra="allow", so they were untyped, unvalidated, and undocumented.ModelInfo.embedding_dimensions— vector size for embedding models (omitted otherwise).Features.chat_completion,Features.responses_api— available-endpoint flags.Features.reasoning_efforts: list[str]— supersedes the oldreasoning_efforts_supportedboolean.Features.max_tokens_supported,max_completion_tokens_supported,custom_temperature_supported— pre-existing drift behind Core.Defaults stay compatible with older Core versions: booleans default to
None,reasoning_effortsdefaults to[](Core always emits it as an array). README sample responses updated for the new fields.Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.