Move embedded GLSL code to separate files #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
Sorry, this version fails volume rendering. For now, I fixed it but there are some codeclimat issues |
paulsmirnov
requested review from
paulsmirnov
and removed request for
NataliaDSmirnova
paulsmirnov
approved these changes
Jun 18, 2019
Member
paulsmirnov
left a comment
paulsmirnov
left a comment
There was a problem hiding this comment.
Good job. It will be much easier to work with shaders this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Move embedded GLSL code to separate files.
Remove *.glsl shader files extension. Now used *.vert and *.frag.
Type of changes
Checklist
yarn run ci: lint and tests pass locally with my changes.