Open
Conversation
| rootReducer, | ||
| window.__REDUX_DEVTOOLS_EXTENSION__ && window.__REDUX_DEVTOOLS_EXTENSION__(), | ||
| ); | ||
| const store = configureStore({ |
Collaborator
There was a problem hiding this comment.
What do you think about moving Redux store creation to a separate file?
|
|
||
| const mapStateToProps = () => ({ | ||
| }); | ||
| const AboutPanelContainer = (props) => ( |
Collaborator
There was a problem hiding this comment.
Sorry, I'm confused
Could you clarify why does it needed? Looks like a component that simply resends all received props to the only one child
| name: 'visiblePanels', | ||
| initialState: {}, | ||
| reducers: { | ||
| showNav: (state) => { |
Collaborator
There was a problem hiding this comment.
A little bit concerned about naming
As I understand it's a "toggle" action, however, name started from "show" looks like more about one way action (not about returning back to hide something)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #635
This change modernizes the
miew-appRedux setup and reduces boilerplate while keeping the existing UI behavior intact. It migrates the store to Redux Toolkit, moves reducers to slices with action re-exports, and updates containers to hooks-based usage.Type of changes
Checklist
yarn run ci: lint and tests pass locally with my changes.