Use miew-react in miew-app viewer#656
Merged
paulsmirnov merged 1 commit intomainfrom May 5, 2026
Merged
Conversation
NadezhdaKatcman
approved these changes
May 5, 2026
Collaborator
NadezhdaKatcman
left a comment
NadezhdaKatcman
left a comment
There was a problem hiding this comment.
Looks good, thank you!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Closes #583.
The
miew-appviewer previously implemented its own Miew lifecycle management directly inMiewViewer.jsx, bypassing themiew-reactwrapper entirely. This change replaces that custom component with a newMiewViewportcomponent that delegates rendering tomiew-react.MiewViewer.jsxand replaced it withMiewViewport.jsxwhich uses theViewercomponent frommiew-reactMiewViewerContainer→MiewViewportContainerto matchmiew-reactas an explicit dependency ofmiew-appMiewModule/MiewStyleswebpack aliases that were only needed by the old componentMiewViewportType of changes
Checklist
yarn run ci: lint and tests pass locally with my changes.