This repository was archived by the owner on Jul 7, 2022. It is now read-only.
Add the pool screens and associated states#316
Merged
alexandrepiveteau merged 24 commits intomainfrom May 9, 2022
Merged
Conversation
…mpute grid placeable size
alexandrepiveteau
requested review from
BadrTad,
Fouad-sys,
KurohanaJuri,
barmettlerl and
matt989253
alexandrepiveteau
added
the
update-me-please
Fouad-sys
previously approved these changes
May 8, 2022
Contributor
Fouad-sys
left a comment
Fouad-sys
left a comment
There was a problem hiding this comment.
Very neat and well done screens, Great job!
mobile/src/main/java/ch/epfl/sdp/mobile/ui/tournaments/PoolCard.kt
Outdated
Show resolved
Hide resolved
…d.kt Co-authored-by: Fouad-sys <61212919+Fouad-sys@users.noreply.github.com>
matt989253
reviewed
May 9, 2022
Contributor
matt989253
left a comment
matt989253
left a comment
There was a problem hiding this comment.
Great job! Looks amazing!
Concerning the colors not being in MaterialTheme, I think if we wish to do something about it it would require it's own feature with a custom material theme so you can probably ignore my comment for this PR.
…le.kt Co-authored-by: Matthieu Burguburu <matthieu.burguburu@gmail.com>
matt989253
approved these changes
May 9, 2022
|
Code Climate has analyzed commit ecb67a2 and detected 0 issues on this pull request. The test coverage on the diff in this pull request is 98.4% (80% is the threshold). This pull request will bring the total coverage in the repository to 97.9% (0.1% change). View more on Code Climate. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds support for the pools screens (see Figma). For convenience, some
@Previewcan be found in this Gist : https://gist.github.com/alexandrepiveteau/4287fbe9f2fc1a5739bfc45b9fec4fb0.Deliverables