Optimized differential privacy implementation#997
Merged
Conversation
tharvik
requested changes
Dec 8, 2025
Collaborator
tharvik
left a comment
There was a problem hiding this comment.
thanks for the great work! I added a few comments on how to improve parts of it but the core feature is there 🎉
btw, I don't remember if we talked about adding a test for the feature. for an integration test, you can add one in server/tests/e2e/federated.spec.ts trying out the feature and if you have some hardening/units tests in mind, you can also some in discojs/src/privacy.spec.ts to ensure that it works in many conditions.
136b2ce to
7fcc166
Compare
tharvik
approved these changes
Feb 3, 2026
Collaborator
tharvik
left a comment
There was a problem hiding this comment.
updated it a bit with the latest changes for byzantine impl, thanks for the huge contributions!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Gaussian noise calibration implementation
Adaptive clipping mechanism
cli testing tool modification
Webapp interface updates