Revert PR #75 — drop arm64/macOS matrix gating now that runners are permanent#80
Merged
Conversation
…ue-on-error" This reverts PR #75 (commit 6bc1e59). The premise of #75 was that Linux arm64 and macOS arm64 jobs sat Pending forever because no runners with those labels were online — the `if: vars.HAS_X_RUNNER` guard would skip them so PRs didn't look stuck. Self-hosted runners for both labels are now permanent, so the gating just turns into a footgun: the `vars.HAS_*_RUNNER` repo variables aren't set, which means new PRs would mark both jobs Skipped even though real runners are ready to pick them up. Better to drop the gating and let the matrix run normally. Also removes `continue-on-error: true` on both jobs — when the runners are real, a failure on arm64 or macOS should block PR merges the same way Linux and Windows already do. If a runner goes offline temporarily, a brief Pending state is the correct signal — the long-term fix is to bring the runner back, not to teach CI to hide it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #75
PR #75 added `if: ${{ vars.HAS__RUNNER == 'true' }}` + `continue-on-error: true` to the `Build (Linux arm64)` and `Build (macOS arm64)` matrix jobs. The motivation was that those jobs sat Pending forever on every PR because no self-hosted runners with those labels were online — the `if:` guard would mark them Skipped instead.
You've since added permanent runners for both labels. With the gating in place but the repo variables unset (`gh variable list` returns empty), new PRs would now mark both jobs Skipped even though real runners are ready to pick them up — exactly the wrong outcome.
Also removes `continue-on-error: true` so a real failure on arm64 or macOS blocks PR merges the same way Linux and Windows do today. If a runner goes offline temporarily, a brief Pending state is the correct signal; the fix is to bring the runner back, not to teach CI to hide it.
Test plan
If something does go wrong with the arm64 or macOS runners in the future, a tighter version (just `continue-on-error` on `Build (macOS arm64)` for known Apple-environmental flake, no `if:` guard) is easy to add back.