Merged
Conversation
Owner
|
Thanks for the contribution! Code looks good! I'll add a license file ASAP. Perhaps I can manage to do it before the merge |
0xAdk
force-pushed
the
feat/vim_keybinds
branch
from
e1d0d61 to
1d45b3b
Compare
0xAdk
force-pushed
the
feat/vim_keybinds
branch
from
1d45b3b to
c43e375
Compare
Contributor
Author
|
Ok, I rebased it on top of the commit with the license file and I noticed that I left a formatting error in so fixed that after. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the repo doesn't have a license I'm not sure how merging this would work. So I'll just say my code is under MIT or Apache-2.0 since it's common for rust.
I can drop the
run clippy --fix(c02b34f) commit if you want.