Epid (using EpidSoft support) does not work if ODEL==0

[ralphlange]

A change in c2f4981 introduced a bug in the devSoftEpid Device Support that leads to OVAL never being changed (i.e. controller is disfunctional) when ODEL == 0.

[ralphlange]

Fix:

Index: stdApp/src/devEpidSoft.c
===================================================================
--- stdApp/src/devEpidSoft.c    (working copy)
+++ stdApp/src/devEpidSoft.c    (working copy)
@@ -207,7 +207,7 @@
     pepid->dt   = dt;
     pepid->err  = e;
     pepid->cval  = cval;
-    if ((pepid->odel != 0) && (fabs(pepid->oval - oval) > pepid->odel)) {
+    if ((pepid->odel == 0) || (fabs(pepid->oval - oval) > pepid->odel)) {
         pepid->oval  = oval;
     }
     pepid->p  = p;

[MarkRivers]

Thanks for finding this. Clearly I never tested it after this commit. :-(

[ralphlange]

This might even justify a quick bugfix release - @keenanlang?

[MarkRivers]

Should be fixed with caabd2e

@ralphlange can you test it?

[ralphlange]

I did - this change works for the ODEL==0 case.

Note that I did not test the ODEL functionality, for which the documentation seems to be out-of-date, so I can't be 100% sure what the correct behavior is.

[ralphlange]

Awwww.
As @jeonghanlee points out in #13: the above fix is fine, the caabd2e commit is not.

[jeonghanlee]

@ralphlange , please check the pull request.

[ralphlange]

Not fixed by caabd2e, correct.

[jeonghanlee]

It was fixed with missing {. At the same time, I was working for ESS std module in order to upgrade the latest version. :)

[ralphlange]

I did the same upgrade for CODAC Core System today, that's when I found epid had stopped working. (CCS adds a few tests to verify basic functionality.)
Obviously, I had fixed the issue for the CCS code (see above diff), so I didn't follow the details of merging it upstream.
Issue fixed with merging #13 by 7aabaf1.

@keenanlang: sorry that jump was too short...

[keenanlang]

Updated the bugfix release to point to correctly fixed commit.