Skip to content

Conversation

@frankcalise
Copy link
Contributor

Tested this and it works locally on Windows 10 with vscode. Would need someone to test the regex on Mac as I don't have one.

I imagine this could be done to the other projects as I remember having this issue in learn-react-hooks as well.

Tested this and it works locally on Windows 10 with vscode. Would need someone to test the regex on Mac as I don't have one.

I imagine this could be done to the other projects as I remember having this issue in learn-react-hooks as well.
@codecov
Copy link

codecov bot commented May 11, 2019

Codecov Report

Merging #7 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master       #7   +/-   ##
=======================================
  Coverage   59.37%   59.37%           
=======================================
  Files          14       14           
  Lines         256      256           
  Branches       13       13           
=======================================
  Hits          152      152           
  Misses         99       99           
  Partials        5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a7a1c71...fdf7740. Read the comment docs.

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll bet that works just fine on mac. I'll test it to be sure, but I expect it works fine.

Thank you so much Frank. You've been awesome!

@kentcdodds kentcdodds merged commit d79dc39 into epicweb-dev:master May 11, 2019
SpencerHaan pushed a commit to SpencerHaan/advanced-react-hooks that referenced this pull request Jan 25, 2022
* docs: update README.md

* docs: update .all-contributorsrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants