fix: redis 4 adapter not an integer or out of range error#18
Merged
Xiphe merged 1 commit intoepicweb-dev:mainfrom Dec 14, 2022
Merged
fix: redis 4 adapter not an integer or out of range error#18Xiphe merged 1 commit intoepicweb-dev:mainfrom
Xiphe merged 1 commit intoepicweb-dev:mainfrom
Conversation
Collaborator
|
Cool 👍 thanks for the contribution |
Collaborator
|
damn, hit enter to early while editing the commit message. My bad 😅 |
|
🎉 This PR is included in version 3.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR
Math.ceil()to the redisAdapter EXAT parameter to preventERR value is not an integer or out of rangeerrors with real redis instancesCloses #17
Please note that you can entirely disregard my PR if you have a better solution. If I had time, I would have changed the tests in a way, that
Date.now()would return a more real-like timestamp, but that would also require me to update all other tests.