Skip to content

use consistent Promise<T> return type for callback #23

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 27, 2024
Merged

use consistent Promise<T> return type for callback #23

merged 2 commits into from
Jun 27, 2024

Conversation

@kettanaito
Copy link
Member

@kettanaito kettanaito commented Jun 27, 2024 •
edited
Loading

  • Follow-up to Fix global test return type #22. Now all exercises after 03/01 annotate the return type of the callback argument as potentially async.
  • Adds a callout about the return type change so it's apparent to the developer.

@kettanaito kettanaito merged commit 35fed36 into main Jun 27, 2024
@kettanaito kettanaito deleted the consistent-async-return-type branch June 27, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@kettanaito