Skip to content

Replace remove_na_observed_predicted() by na.omit() #404

@nikosbosse

Description

@nikosbosse

We currently have a function remove_na_observed_predicted() that removes all rows where either predicted or observed is NA.

I think it would be good to simply replace this function by na.omit().

Reasoning:

  • Having NA values anywhere in the data (not just in observed and predicted) is potentially risky and could break things (e.g. mess up grouping according to the forecast unit). Handling this makes things more complicated.
  • na.omit() is a known function. Having (and exporting) a function that just removes NA values in certain columns seems unnecessarily complicated).

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    Status

    Done

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions