Merged
Conversation
Added `CountAsOne: ['array', 'hash', 'heredoc', 'method_call']` to Metrics/ClassLength and Metrics/MethodLength
now alphabetically sorted
as per other integrations for metrics
- `:thread_count`: The number of threads currently alive - `:process_threads`: The number of currently running threads
mirrors the current approach in the other HMLR apps
Reorganised makefile targets alphabetically as well as mirrored other improvements from the other applications in the suite
from v1.9.5 ~> 1.9.6
Additional metrics from the Puma server to be exposed in the /metrics endpoint via the `puma-metrics` gem
alongside adding labels to be able to fine-tune the metrics
also improved doc comments
`rescue_from` handlers are inherited. They are searched from right to left, from bottom to top, and up the hierarchy, which meant the exception handler was the only handler firing as well as preventing the additional filtering for specific errors.
from v1.7.7 ~> 1.7.8
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Focussing primarily on ticket #148 for the addition of Prometheus metrics endpoint to the PPD Explorer, additional changes for accessibility, useability, and functionality have been interspersed.
puma-metricsgem