feat: about page conversion#393
Merged
grudra7714 merged 4 commits intofeat/vue3-upgradefrom Apr 29, 2025
Merged
Conversation
Signed-off-by: Rudra Gupta <grudra7714@gmail.com>
Signed-off-by: Rudra Gupta <grudra7714@gmail.com>
dcharles525
requested changes
Apr 28, 2025
Member
dcharles525
left a comment
dcharles525
left a comment
There was a problem hiding this comment.
I am getting "store is undefined" errors on line 16/17. I think this is also causing the computed values (appName, versionString) to not resolve and display in the UI.
Signed-off-by: Rudra Gupta <grudra7714@gmail.com>
Contributor
Author
|
Signed-off-by: Rudra Gupta <grudra7714@gmail.com>
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Converts about.vue page to vue3 composition api
Fixes https://krumtest.atlassian.net/browse/EPINIO-96?atlOrigin=eyJpIjoiOWI1MGIyMmM3ZmQ2NDM0YmFiZDU3YjQ2NjhhYjJlYjIiLCJwIjoiaiJ9
Occurred changes and/or fixed issues
Technical notes summary
Areas or cases that should be tested
Areas which could experience regressions
Screenshot/Video