Skip to content

feat: use trailhand modal in service delete#549

Merged
johnlcos merged 4 commits intofeat/EPINIO-508-511_service_instancefrom
feat/EPINIO-510__delete_services
Mar 27, 2026
Merged

feat: use trailhand modal in service delete#549
johnlcos merged 4 commits intofeat/EPINIO-508-511_service_instancefrom
feat/EPINIO-510__delete_services

Conversation

@johnlcos
Copy link
Copy Markdown
Collaborator

@johnlcos johnlcos commented Mar 23, 2026

PR Checklist

  • Linting Test is passing
  • Code is well documented
  • If applicable, a PR in the epinio/docs repository has been opened

Summary

Fixes #

Service Instance Deletion

Occurred changes and/or fixed issues

  • Implement trailhand modal for service deletion.

Technical notes summary

  • Refactored some of the logic adding during namespace deletion to be a reusable util. This util accepts the rows, and some config objects for properties to add or override, and then will return the updated rows
  • This is because in order to use the trailhand modal and not the default rancher flow we need to override the promptRemove action on the row

Areas or cases that should be tested

Areas which could experience regressions

Screenshot/Video

image

Copy link
Copy Markdown
Contributor

@Hannahbird Hannahbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlcos johnlcos changed the base branch from 1.14.0 to feat/EPINIO-508-511_service_instance March 27, 2026 16:43
Copy link
Copy Markdown
Contributor

@Hannahbird Hannahbird left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@johnlcos johnlcos merged commit 8680f6d into feat/EPINIO-508-511_service_instance Mar 27, 2026
2 checks passed
@johnlcos johnlcos deleted the feat/EPINIO-510__delete_services branch March 27, 2026 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants