EPiServer v10 support #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merge pull request #4 from valdisiljuconoks/master
* Added web,config.transform to add protected module * Added NuGet package * Bumped version to 2.0
bjuris
approved these changes
Dec 21, 2016
| var ctx = new HttpContextWrapper(new HttpContext (new HttpRequest("", url, ""), new HttpResponse(new StringWriter(new StringBuilder())))); | ||
|
|
||
| if (r.Route is ContentRoute) | ||
| if (r.Route is DefaultContentRoute) |
Member
There was a problem hiding this comment.
Should be able to use IContentRoute to avoid the use of internal namespaces(DefaultContentRoute) and cast r.Route to Route.
Contributor
Author
|
Added some code refactorings. Can you review now? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #7