CG-11483 remove line brakes in bulk content on Linux #10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brucengdev
approved these changes
Mar 19, 2025
huyenvv90
reviewed
Mar 19, 2025
Optimizely.Graph.Source.Sdk/Optimizely.Graph.Source.Sdk/Repositories/GraphSourceRepository.cs
Outdated
Show resolved
Hide resolved
huyenvv90
approved these changes
Mar 19, 2025
Optimizely.Graph.Source.Sdk/Optimizely.Graph.Source.Sdk/Repositories/GraphSourceRepository.cs
Show resolved
Hide resolved
… content in CreateContent
…pretty printed JSON
…nstead of semi-pretty JSON
Contributor
Author
|
I made a few updates to this code, adding tests and minifying the JSON request instead of generating pretty JSON and then stripping line endings. Please review again |
cimdalli
approved these changes
Mar 19, 2025
truongvd1983
approved these changes
Mar 20, 2025
jonasbergqvist
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: Ensure new lines are stripped on both Windows (
\r\n) and Linux (\n) so that bulk content is consistently formatted across all platforms.Changes
SaveContentAsync()to send minified JSON. That solves the issue with line brakes for Linuxdotnet-test-explorer