CG-14844: Graph Source SDK - Journal Id Not Returned #17
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR modifies the Graph Source SDK to return journal IDs from the SaveContentAsync method, enabling developers to track sync status by accessing the stream endpoint. Previously, the method returned an empty string regardless of the API response.
- Added ContentV2ApiResponse model to capture journal ID from API responses
- Modified SaveContentAsync to parse and return the journal ID from the response
- Updated unit tests to verify the new response handling behavior
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| ContentV2ApiResponse.cs | New model class to capture journal ID from API responses |
| GraphSourceRepository.cs | Modified SaveContentAsync to return journal ID instead of empty string |
| GraphSourceRepositoryTests.cs | Updated existing tests and added new test to verify journal ID return behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
...ely.Graph.Source.Sdk/Optimizely.Graph.Source.Sdk/Repositories/Models/ContentV2ApiResponse.cs
Show resolved
Hide resolved
jakeminard
requested review from
ThanhCN85,
brucengdev,
hieu-opti and
ngoctuyennguyen-opti
hieu-opti
approved these changes
Sep 12, 2025
hieu-opti
left a comment
hieu-opti
left a comment
There was a problem hiding this comment.
Approved.
Tests were executed and passed
New tests added locally to address edge cases passed
jonasbergqvist
approved these changes
Sep 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CG-14844: Graph Source SDK - Journal Id Not Returned
When something is synced in graph-source-sdk, the content will go through _stream. To be able to know the status for the synced content, we would need to be able to see the return from the service, but this is not happening in SaveContentAsync.
The response body looks like this:
With the information, a developer would be able to see why sync is failing by hitting this path (while being authenticated).