Fix # nolint flag linter exclusion syntax#263
Merged
joshwlambert merged 3 commits intomainfrom Nov 20, 2025
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes the syntax of
# nolintflags in the code that specify a specific linter to exclude for that line or chunk of lines. Previously, the linter wanting to be excluded was specified but not recognised by {lintr} due to not using the# nolint: linter_name, linter2_name.syntax, specifically not using a colon or full stop. See https://lintr.r-lib.org/reference/exclude.html.The specific linter being excluded has been removed from
# nolint endstatements as it is not required, see https://lintr.r-lib.org/articles/lintr.html#excluding-multiple-lines-of-codes.Lines that had a
# nolintflag that caused the line to exceed 80 characters have been converted into# nolint startand# nolint endstatements, to avoid having to also specify theline_length_linter, making that line of code exceedingly long.The vignettes that include
# nolintflags in code chunks have also been updated to onlyechothe functional code and user-intended comments.