Conversation
| if os.getenv('EPSAGON_LOGGING_TRACING_ENABLED'): | ||
| return os.getenv('EPSAGON_LOGGING_TRACING_ENABLED').upper() == 'TRUE' | ||
|
|
||
| return True |
There was a problem hiding this comment.
| if os.getenv('EPSAGON_LOGGING_TRACING_ENABLED'): | |
| return os.getenv('EPSAGON_LOGGING_TRACING_ENABLED').upper() == 'TRUE' | |
| return True | |
| return os.getenv('EPSAGON_LOGGING_TRACING_ENABLED', 'TRUE').upper() == 'TRUE' |
| print_debug('[aiohttp] got response') | ||
| except Exception as exception: # pylint: disable=W0703 | ||
| # Ignoring 404s | ||
| if type(exception).__name__ == 'HTTPNotFound': |
There was a problem hiding this comment.
can we import the specific exception class and compare the types objects?
| _single_wrapper | ||
| ) | ||
| # Version < 3.0 | ||
| wrapt.wrap_function_wrapper( |
There was a problem hiding this comment.
to make sure, in newer versions this call won't explode - right?
There was a problem hiding this comment.
That's right, this code is failsafe
|
|
||
| # Ignoring 404s | ||
| if getattr(instance, '_status_code', None) == 404: | ||
| print_debug('Ignoring 404 Tornado request') |
There was a problem hiding this comment.
should pop the trace from trace_factory (and prevent memory leaks for those 404 traces)
| body | ||
| ) | ||
| except Exception as exception: # pylint: disable=broad-except | ||
| print_debug('Could not extract body: {}'.format(exception)) |
There was a problem hiding this comment.
| print_debug('Could not extract body: {}'.format(exception)) | |
| print_debug('Could not extract request body: {}'.format(exception)) |
| if response_body: | ||
| body = response_body | ||
| if isinstance(body, list): | ||
| body = body[0] |
There was a problem hiding this comment.
in which cases is the body list? (wondering whether we want to collect all the list items)
There was a problem hiding this comment.
It seems to be always a list from what I've seen, and always a single element
|
🎉 This PR is included in version 1.61.14 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
3 participants
In addition: