fix: hot reload on demo#87
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This branch includes fix for linear ticket "Equality's hot-reloading is broken"
Issue:
After upgrading to Astro 6 (Vite 7), editing UI components or their styles no longer hot-reloaded, meaning changes only appeared after a manual
pnpm build. Vite 7's per-environment resolution stopped applyingresolve.aliasin the SSR environment, so server-rendered docs components loaded the builtdist/output instead of../ui/src.Fix:
Replaced the
@eqtylab/equalityalias (plus redundantssr.noExternal) inpackages/demo/astro.config.mjswith two small Vite plugins: aresolveIdhook that pins the package to its source in every environment (incl. SSR), and a watcher plugin that adds the out of root../ui/srcto Vite's dev watcher. Edits to UI components/styles now trigger an auto-reload in the dev server.