Add build_unsigned_with_eqty_contexts helper#22
Merged
Conversation
The previous downstream pattern in integrity-monorepo had two call sites (vcomp evidence VC, policy compliance VC) each manually constructing a `JsonCredential` via `JsonCredential::new(...)` + `context.insert(...)`, reaching directly into ssi (`IdOr`, `NonEmptyVec`, `NonEmptyObject`, `ContextEntry::IriRef`), iref (`UriBuf`, `IriRefBuf`), and xsd-types (`DateTimeStamp`). That meant every caller had to learn the ssi-internal type marshalling, and the EQTY context bundle (v2 base + security/v2 + `ig_common_context_link()`) was restated inline in two places — risking drift if a third entry is ever added. Move that ceremony upstream. Callers now hand over their semantic inputs (id, issuer DID, subject JSON, optional valid_from / valid_until, and evidence entries as JSON values) and get back an unsigned `JsonCredential` ready to feed to `sign_vc`. The EQTY-flavored `@context` bundle is attached by the helper, so changes to the bundle live in one place. Tests cover: - vcomp-shape VC (subject + custom EQTY evidence terms) — sign and verify end-to-end through the new helper. - compliance-shape VC (policy-subject struct, `valid_until` set, no evidence) — same. - Non-object subject rejected with a clear error rather than a panic. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
TJbrunk
approved these changes
May 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstream of https://github.com/eqtylab/integrity-monorepo/pull/1640