feat: remove Equinix Metal (metalv1) from the SDK#96
Open
turegano-equinix wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
None of the failing checks are caused by the metalv1 removal.
This is the same preexisting Fabric bug seen locally (the broken CHANGE_LOG_SLASH_... enum). The stale patch is exactly what produces that broken enum. This branch does not touch Fabric's patches/ or Makefile.fabricv4. It only removed patches/services/metalv1/.keep. The failure already exists on main.
|
ctreatma
approved these changes
Jun 30, 2026
ctreatma
left a comment
Contributor
There was a problem hiding this comment.
Looks good. I see that the Fabric generation issue exists elsewhere but was being masked by the successful Metal generation afterwards.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes all Equinix Metal (metalv1) code ahead of its end-of-sale on June 30, 2026