feat: make json format optional in stead of a forced default #32
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…arameter handling
Qif-Equinor
approved these changes
Nov 12, 2025
TordAreStromsnes
pushed a commit
that referenced
this pull request
Nov 12, 2025
🤖 I have created a release *beep* *boop* --- ## [0.4.0](v0.3.0...v0.4.0) (2025-11-12) ### Features * make json format optional in stead of a forced default ([#32](#32)) ([735f490](735f490)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We cannot download the bin files from the endpoint if format is set to json, so we have to make this an optional parameter in the endpoint.
QueryBuilder API improvements:
QueryBuilder.format()to omit the$formatparameter by passing an empty string orNone, and updated the default to"json".Query parameter construction:
build_query_paramsinodata.pyto only include the$formatparameter if it is not empty orNone.Documentation updates:
query-builder.mddocumenting how to use the.format()method, including examples for omitting the parameter.