Skip to content

Comments

Add some logging for the queues#10396

Merged
frode-aarstad merged 1 commit intoequinor:mainfrom
frode-aarstad:add-logging-for-queues
Mar 28, 2025
Merged

Add some logging for the queues#10396
frode-aarstad merged 1 commit intoequinor:mainfrom
frode-aarstad:add-logging-for-queues

Conversation

@frode-aarstad
Copy link
Contributor

@frode-aarstad frode-aarstad commented Mar 20, 2025

Issue
Resolves #9618

When running everest with the --debug flag we now provide logs from websockets with sizes of the events:


2025-03-20 08:37:53,241 websockets.client DEBUG: < TEXT '{"batch":4,"event_type":"EverestBatchResultEven...e_names":["distance"]}}' [2342 bytes]
2025-03-20 08:37:53,342 websockets.client DEBUG: < TEXT '{"batch":5,"event_type":"EverestStatusEvent","e..._OPTIMIZER_EVALUATION"}' [90 bytes]

Also added a test for logging from plugins

(Screenshot of new behavior in GUI if applicable)

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Create Backport PR to latest release

@frode-aarstad frode-aarstad added the release-notes:skip If there should be no mention of this in release notes label Mar 20, 2025
@frode-aarstad frode-aarstad self-assigned this Mar 20, 2025
@codspeed-hq
Copy link

codspeed-hq bot commented Mar 20, 2025

CodSpeed Performance Report

Merging #10396 will not alter performance

Comparing frode-aarstad:add-logging-for-queues (2fb3705) with main (b5b4abf)

Summary

✅ 25 untouched benchmarks

@frode-aarstad frode-aarstad force-pushed the add-logging-for-queues branch 2 times, most recently from 242799c to a9d06f0 Compare March 25, 2025 09:14
Copy link
Contributor

@DanSava DanSava left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

I assume it was not possible to split the changes in two commits to reflect the two issues you are closing. One related to logging and one related to handling connection errors

Also some conflicts need to resolved before merging.

@frode-aarstad frode-aarstad force-pushed the add-logging-for-queues branch from a9d06f0 to 2fb3705 Compare March 28, 2025 09:04
@frode-aarstad
Copy link
Contributor Author

Looks good 👍

I assume it was not possible to split the changes in two commits to reflect the two issues you are closing. One related to logging and one related to handling connection errors

Also some conflicts need to resolved before merging.

I removed the issue with the websocket handeling as its not fixed and put it back in todo

@frode-aarstad frode-aarstad merged commit f250747 into equinor:main Mar 28, 2025
27 checks passed
@frode-aarstad frode-aarstad deleted the add-logging-for-queues branch March 28, 2025 11:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:skip If there should be no mention of this in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Investigate the data usage when sending snapshots

2 participants