Add some logging for the queues#10396
Merged
frode-aarstad merged 1 commit intoequinor:mainfrom Mar 28, 2025
Merged
Conversation
CodSpeed Performance ReportMerging #10396 will not alter performanceComparing Summary
|
242799c to
a9d06f0
Compare
DanSava
reviewed
Mar 28, 2025
Contributor
DanSava
left a comment
There was a problem hiding this comment.
Looks good 👍
I assume it was not possible to split the changes in two commits to reflect the two issues you are closing. One related to logging and one related to handling connection errors
Also some conflicts need to resolved before merging.
a9d06f0 to
2fb3705
Compare
Contributor
Author
I removed the issue with the websocket handeling as its not fixed and put it back in todo |
DanSava
approved these changes
Mar 28, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Resolves #9618
When running everest with the --debug flag we now provide logs from websockets with sizes of the events:
Also added a test for logging from plugins
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable