-
Notifications
You must be signed in to change notification settings - Fork 123
Unpin polars #12475
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Unpin polars #12475
Conversation
|
Tests fail due to bug in polars, will need to wait for 1.26.1 release. |
22695c4 to
4dc1235
Compare
|
Now it fails on the following issue: Could maybe reevaluate if there are better ways of applying the transformations. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12475 +/- ##
==========================================
- Coverage 90.67% 90.64% -0.04%
==========================================
Files 429 429
Lines 29803 29803
==========================================
- Hits 27025 27015 -10
- Misses 2778 2788 +10
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR unpins the polars library version constraint to allow upgrading from version 1.34.0 to 1.37.1, while excluding problematic versions 1.26.0 and 1.35.
Changes:
- Updated polars version constraint from
>=1.32.3, <1.35to>=1.32.3, !=1.35, !=1.26.0in pyproject.toml - Replaced deprecated
return_dtypeparameter inmap_elements()calls with.cast()method calls (polars API change) - Added defensive check to filter empty arrays in RFT configuration list comprehension
- Added column ordering normalization in DataFrame comparison utility function
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| uv.lock | Updates polars and polars-runtime-32 from 1.34.0 to 1.37.1 |
| pyproject.toml | Relaxes polars version constraint to allow 1.37.1 while excluding problematic versions |
| tests/ert/ui_tests/cli/test_field_parameter.py | Removes unused Float32 import, replaces return_dtype with .cast(), adds column ordering fix |
| src/ert/storage/local_ensemble.py | Replaces return_dtype parameter with .cast() method |
| src/ert/gui/tools/manage_experiments/storage_info_widget.py | Replaces return_dtype parameter with .cast() method |
| src/ert/config/rft_config.py | Adds empty array check to prevent issues with polars concat |
frode-aarstad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
Will this need to be back-ported or mentioned in the release notes @xjules ? |
Issue
Resolves #12218
git rebase -i main --exec 'just rapid-tests')When applicable