-
Notifications
You must be signed in to change notification settings - Fork 121
Have _create_run_path log exactly what parameter type is hanging #12552
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12552 +/- ##
==========================================
- Coverage 90.62% 90.62% -0.01%
==========================================
Files 432 432
Lines 29738 29748 +10
==========================================
+ Hits 26951 26959 +8
- Misses 2787 2789 +2
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
734a850 to
95c2dc1
Compare
CodSpeed Performance ReportMerging #12552 will not alter performanceComparing Summary
|
| fs: Ensemble from which to load parameter data | ||
| Returns: | ||
| Returns the union of parameters returned by write_to_runpath for each |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should this be updated to reflect the change of return object?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, this is hopefully just here temporarily (but probably not)...
95c2dc1 to
5c6ee5b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR adds detailed timing instrumentation to the _generate_parameter_files function to identify which parameter type might be causing performance issues during run path creation. The main changes include tracking timing for individual parameter type exports and aggregating these detailed timings in the create_run_path function's existing timing dictionary.
- Modified
_generate_parameter_filesto return both parameter data and detailed timing information - Added timing measurements for each parameter type export operation and file I/O operations
- Aggregated parameter-specific timings in the main
create_run_pathfunction
| for group, vals in log_export_values.items(): | ||
| log_exports.setdefault(group, {}).update(vals) | ||
| export_timings[param.type] += time.perf_counter() - start_time | ||
| continue |
Copilot
AI
Jan 5, 2026
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The continue statement at the end of the loop is redundant and should be removed. Since this is the last statement in the loop body, execution will naturally continue to the next iteration without an explicit continue statement.
| continue |
frode-aarstad
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🚀
|
Backport failed for Please cherry-pick the changes locally and resolve any conflicts. git fetch origin version-18.0
git worktree add -d .worktree/backport-12552-to-version-18.0 origin/version-18.0
cd .worktree/backport-12552-to-version-18.0
git switch --create backport-12552-to-version-18.0
git cherry-pick -x 33439f80a133249194a8f50fc8abe18460c4ff60 |
Issue
Resolves #my_issue
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable