Skip to content

Make migration deterministic over filesystem#12865

Merged
berland merged 1 commit intoequinor:mainfrom
berland:fix_flaky_glob
Feb 13, 2026
Merged

Make migration deterministic over filesystem#12865
berland merged 1 commit intoequinor:mainfrom
berland:fix_flaky_glob

Conversation

@berland
Copy link
Contributor

@berland berland commented Feb 13, 2026

The test of this function has exposed flakyness, which can be reproduced by tweaking the order of files returned by glob().

pathlib.Path.glob() returns filenames in arbitrary order.

Issue
Resolves #12863

Approach
🧠

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

The test of this function has exposed flakyness, which can be reproduced by tweaking
the order of files returned by glob().

pathlib.Path.glob() returns filenames in arbitrary order.
@berland berland added the release-notes:skip If there should be no mention of this in release notes label Feb 13, 2026
@berland berland added this to SCOUT Feb 13, 2026
@berland berland moved this to Fast Track in SCOUT Feb 13, 2026
@berland berland enabled auto-merge (rebase) February 13, 2026 10:54
@berland berland added release-notes:flaky-test-fix PR fixes a flaky test and removed release-notes:skip If there should be no mention of this in release notes labels Feb 13, 2026
@berland berland self-assigned this Feb 13, 2026
@github-project-automation github-project-automation bot moved this from Fast Track to Reviewed in SCOUT Feb 13, 2026
@codecov-commenter
Copy link

codecov-commenter commented Feb 13, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.63%. Comparing base (673fdcb) to head (c8c240b).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12865      +/-   ##
==========================================
- Coverage   90.64%   90.63%   -0.01%     
==========================================
  Files         440      440              
  Lines       30460    30460              
==========================================
- Hits        27610    27607       -3     
- Misses       2850     2853       +3     
Flag Coverage Δ
cli-tests 37.21% <0.00%> (ø)
gui-tests 67.88% <0.00%> (ø)
performance-and-unit-tests 77.05% <100.00%> (-0.01%) ⬇️
test 37.35% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@berland berland merged commit e624b66 into equinor:main Feb 13, 2026
37 checks passed
@github-project-automation github-project-automation bot moved this from Reviewed to Done in SCOUT Feb 13, 2026
@scout-team-app
Copy link

Successfully created backport PR for version-20.0:

@codspeed-hq
Copy link

codspeed-hq bot commented Feb 13, 2026

Merging this PR will not alter performance

✅ 34 untouched benchmarks


Comparing berland:fix_flaky_glob (c8c240b) with main (673fdcb)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

Flaky test: migration/test_to25.py::test_that_migration_creates_experiment_index_with_params_responses_and_obs_configs

3 participants