Make migration deterministic over filesystem#12865
Merged
berland merged 1 commit intoequinor:mainfrom Feb 13, 2026
Merged
Conversation
The test of this function has exposed flakyness, which can be reproduced by tweaking the order of files returned by glob(). pathlib.Path.glob() returns filenames in arbitrary order.
yngve-sk
approved these changes
Feb 13, 2026
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #12865 +/- ##
==========================================
- Coverage 90.64% 90.63% -0.01%
==========================================
Files 440 440
Lines 30460 30460
==========================================
- Hits 27610 27607 -3
- Misses 2850 2853 +3
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Successfully created backport PR for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test of this function has exposed flakyness, which can be reproduced by tweaking the order of files returned by glob().
pathlib.Path.glob() returns filenames in arbitrary order.
Issue
Resolves #12863
Approach
🧠
git rebase -i main --exec 'just rapid-tests')When applicable