[Backport version-21.0] Fix misfit plot attribute error if missing observations or missing misfit data#13262
Merged
jonathan-eq merged 2 commits intoversion-21.0from Apr 8, 2026
Merged
Conversation
9 tasks
This commit fixes the issue where the misfit plotter would fail with `AttributeError: 'NoneType' object has no attribute 'T'` if observations for an ensemble was missing. Now, it will plot a message `No observations available` (cherry picked from commit 4e8f66a)
This commit fixes the issue where the misfit plotter would fail with `TypeError: unsupported operand type(s) for -: 'NoneType' and 'NoneType` if misfit data for an ensemble was missing. Now, it will plot a message `No misfit data available`. (cherry picked from commit 9282252)
jonathan-eq
force-pushed
the
backport-13254-to-version-21.0
branch
from
48ce5bb to
9078cc7
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## version-21.0 #13262 +/- ##
================================================
- Coverage 90.55% 90.53% -0.02%
================================================
Files 454 454
Lines 31256 31267 +11
================================================
+ Hits 28303 28309 +6
- Misses 2953 2958 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Backport of #13254 to
version-21.0.