Ensure cond field in heat equation is reshaped in f-order#13384
Merged
larsevj merged 1 commit intoequinor:mainfrom Apr 22, 2026
Merged
Ensure cond field in heat equation is reshaped in f-order#13384larsevj merged 1 commit intoequinor:mainfrom
larsevj merged 1 commit intoequinor:mainfrom
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #13384 +/- ##
==========================================
+ Coverage 90.00% 90.02% +0.02%
==========================================
Files 457 457
Lines 31803 31803
==========================================
+ Hits 28623 28632 +9
+ Misses 3180 3171 -9
Flags with carried forward coverage won't be shown. Click here to find out more. |
dafeda
approved these changes
Apr 22, 2026
Collaborator
dafeda
left a comment
There was a problem hiding this comment.
Nice catch! This does look better.
b1a31bd to
dd5f682
Compare
dd5f682 to
b009470
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before change:
After change:
git rebase -i main --exec 'just rapid-tests')When applicable