Skip to content

Ensure cond field in heat equation is reshaped in f-order#13384

Merged
larsevj merged 1 commit intoequinor:mainfrom
larsevj:ensure_cond_field_reshaped_in_fortran_order
Apr 22, 2026
Merged

Ensure cond field in heat equation is reshaped in f-order#13384
larsevj merged 1 commit intoequinor:mainfrom
larsevj:ensure_cond_field_reshaped_in_fortran_order

Conversation

@larsevj
Copy link
Copy Markdown
Collaborator

@larsevj larsevj commented Apr 22, 2026

Before change:

image image image

After change:

image image image
  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Apr 22, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 90.02%. Comparing base (d6b790b) to head (b009470).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #13384      +/-   ##
==========================================
+ Coverage   90.00%   90.02%   +0.02%     
==========================================
  Files         457      457              
  Lines       31803    31803              
==========================================
+ Hits        28623    28632       +9     
+ Misses       3180     3171       -9     
Flag Coverage Δ
cli-tests 37.42% <ø> (ø)
fuzz 44.27% <ø> (ø)
gui-tests 67.04% <ø> (ø)
performance-and-unit-tests 77.99% <ø> (+0.09%) ⬆️
test 45.94% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 3 files with indirect coverage changes

Copy link
Copy Markdown
Collaborator

@dafeda dafeda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch! This does look better.

@larsevj larsevj force-pushed the ensure_cond_field_reshaped_in_fortran_order branch from b1a31bd to dd5f682 Compare April 22, 2026 10:29
@larsevj larsevj force-pushed the ensure_cond_field_reshaped_in_fortran_order branch from dd5f682 to b009470 Compare April 22, 2026 10:54
@larsevj larsevj merged commit 6797728 into equinor:main Apr 22, 2026
44 checks passed
@larsevj larsevj deleted the ensure_cond_field_reshaped_in_fortran_order branch April 22, 2026 11:38
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Apr 22, 2026

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing larsevj:ensure_cond_field_reshaped_in_fortran_order (b009470) with main (d6b790b)

Open in CodSpeed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants