Merged
Conversation
mferrera
commented
Mar 21, 2025
Comment on lines
+9
to
11
| token: str, | ||
| host: str = "127.0.0.1", | ||
| port: int = 8001, |
Collaborator
Author
There was a problem hiding this comment.
It's not used yet. This has to be added in the API-exported run_server next.
667a145 to
7480c15
Compare
joargr
reviewed
Mar 24, 2025
7480c15 to
35edda3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #1
Adds a generate token function to pass an authentication token to the API/GUI threads. It also passes it to the React app as URL fragment. Although our security concerns are less severe given we are executing on TGX nodes where users are already authenticated, this adds some additional protection against someone using the same node and navigating to
localhost:8000and hijacking a session. It will also disallow un-authenticated post requests to the API.Additional this adds some extra tests which were not added when the repository was initialized.
Checklist
--cov=<packagename> --cov-report term-missing)