Skip to content

fix: manage dns alias in radixconfig file#121

Merged
Richard87 merged 3 commits intomasterfrom
1918-refactor-custom-aliases-for-radix-core-apps-from-radix-flux-to-radixconfig
Mar 4, 2026
Merged

fix: manage dns alias in radixconfig file#121
Richard87 merged 3 commits intomasterfrom
1918-refactor-custom-aliases-for-radix-core-apps-from-radix-flux-to-radixconfig

Conversation

@Richard87
Copy link
Copy Markdown
Contributor

No description provided.

Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR restructures Radix application configuration to support managing dnsAlias via generated Radix config files, and updates the build/CI toolchain accordingly.

Changes:

  • Replaced the single radixconfig.yaml with a template (radixconfig.tpl.yaml) and multiple generated Radix config variants (radixconfig.*.yaml) containing dnsAlias.
  • Added make radixconfigs and wired it into make generate/verify-generate to keep generated configs in sync.
  • Updated Go/tooling versions and adjusted CI to validate the new Radix config files.

Reviewed changes

Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
radixconfig.yaml Removed the previous single Radix config file.
radixconfig.tpl.yaml Added a template Radix config with dnsAlias driven by ${ENV} substitution.
radixconfig.{dev,c2,c3,platform,playground}.yaml Added generated Radix config files with concrete dnsAlias.environment values.
Makefile Added a generation target for Radix configs and included it in generate.
go.mod Bumped Go version directive.
Dockerfile Updated builder image to Go 1.26.0.
.github/workflows/pr.yaml Updated actions versions, lint version, and changed Radix config validation to validate multiple config files.
Comments suppressed due to low confidence (1)

.github/workflows/pr.yaml:17

  • The GitHub Actions expression uses unusual whitespace (${{ github. sha }}). While it may still parse, it’s easy to misread and looks like a typo. Prefer the standard ${{ github.sha }} for clarity/consistency.
        env:
          REF: ${{ github. sha }}
        run: docker build -t radix-github-webhook:${REF##*/} .

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread .github/workflows/pr.yaml
Comment thread Makefile
Comment thread Makefile Outdated
@Richard87 Richard87 requested a review from nilsgstrabo March 4, 2026 12:05
@Richard87 Richard87 merged commit 9f94130 into master Mar 4, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Refactor custom aliases for Radix core apps from radix-flux to radixconfig

3 participants