Conversation
14 tasks
There was a problem hiding this comment.
Pull request overview
This PR restructures Radix application configuration to support managing dnsAlias via generated Radix config files, and updates the build/CI toolchain accordingly.
Changes:
- Replaced the single
radixconfig.yamlwith a template (radixconfig.tpl.yaml) and multiple generated Radix config variants (radixconfig.*.yaml) containingdnsAlias. - Added
make radixconfigsand wired it intomake generate/verify-generateto keep generated configs in sync. - Updated Go/tooling versions and adjusted CI to validate the new Radix config files.
Reviewed changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
radixconfig.yaml |
Removed the previous single Radix config file. |
radixconfig.tpl.yaml |
Added a template Radix config with dnsAlias driven by ${ENV} substitution. |
radixconfig.{dev,c2,c3,platform,playground}.yaml |
Added generated Radix config files with concrete dnsAlias.environment values. |
Makefile |
Added a generation target for Radix configs and included it in generate. |
go.mod |
Bumped Go version directive. |
Dockerfile |
Updated builder image to Go 1.26.0. |
.github/workflows/pr.yaml |
Updated actions versions, lint version, and changed Radix config validation to validate multiple config files. |
Comments suppressed due to low confidence (1)
.github/workflows/pr.yaml:17
- The GitHub Actions expression uses unusual whitespace (
${{ github. sha }}). While it may still parse, it’s easy to misread and looks like a typo. Prefer the standard${{ github.sha }}for clarity/consistency.
env:
REF: ${{ github. sha }}
run: docker build -t radix-github-webhook:${REF##*/} .
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
nilsgstrabo
approved these changes
Mar 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.