Runrms add version listing#480
Runrms add version listing#480jcrivenaes merged 2 commits intoequinor:masterfrom jcrivenaes:runrms-add-version-listing
Conversation
|
Can one of the admins verify this patch? |
| self.lockf = line.replace("\n", "") | ||
| self.locked = True | ||
| break | ||
| lockfiletxt = (pathlib.Path(self.project) / "project_lock_file").read_text() |
There was a problem hiding this comment.
pylint will complain here about missing encoding?
There was a problem hiding this comment.
Did not notice that but have added encoding
| parsed_args.project = parsed_args.project_alt | ||
|
|
||
| if parsed_args.project and parsed_args.project_alt: | ||
| xwarn("Conflict use two types of project input. First argument will win!") |
There was a problem hiding this comment.
Should this not be a hard error?
There was a problem hiding this comment.
I think this is buggy, you will trigger this warning when doing only runrms --project foo
There was a problem hiding this comment.
Corrected to elif on line 306
There was a problem hiding this comment.
Can keep as a soft warning
| "--project", | ||
| "-project", | ||
| dest="project_alt", | ||
| help="RMS project name (alternative version)", |
There was a problem hiding this comment.
Is "alternative version" sufficient for explaining users of runrms --help that there are two ways of supplying the project name, or should it be explained more?
There was a problem hiding this comment.
The idea was full backwards user experience with current rms -project foo. I will explain more
There was a problem hiding this comment.
Detailed explanation added
3 participants
Some background:
The
runrmsscript will soon be an replacement forrmsfor the common user. I.e./global/distbin/rmswill link to/prog/res/roxapi/bin/runrmswrapper which in turn links up the Komodo env and then launchrunrmsfrom subscript.Behind the scene,
runrmswill still use/prog/roxar/rms/rmsand the PR here add a few options that the original script has: