Skip to content

Handle new IndexError message for empty decks in opm 2022.04#497

Merged
asnyv merged 2 commits intoequinor:masterfrom
asnyv:opm202204
Aug 23, 2022
Merged

Handle new IndexError message for empty decks in opm 2022.04#497
asnyv merged 2 commits intoequinor:masterfrom
asnyv:opm202204

Conversation

@asnyv
Copy link
Copy Markdown
Contributor

@asnyv asnyv commented Aug 22, 2022

Error message for requested deck keyword out of range apparently became less descriptive in opm 2022.04
Could alternatively keep the old message as well to support 2021.10, but find it ok to force 2022.04 to be able to catch it if opm switches back to the more descriptive message (have a feeling that it might not have been intended from opm's)

@asnyv asnyv requested a review from berland August 22, 2022 15:06
@ertomatic
Copy link
Copy Markdown

Can one of the admins verify this patch?

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Aug 22, 2022

Codecov Report

Merging #497 (35094c3) into master (1c2591b) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head 35094c3 differs from pull request most recent head a28ed3c. Consider uploading reports for the commit a28ed3c to get more accurate results

@@            Coverage Diff             @@
##           master     #497      +/-   ##
==========================================
- Coverage   87.56%   87.55%   -0.02%     
==========================================
  Files          49       49              
  Lines        7028     7030       +2     
==========================================
+ Hits         6154     6155       +1     
- Misses        874      875       +1     
Impacted Files Coverage Δ
src/subscript/sunsch/sunsch.py 94.77% <100.00%> (-0.34%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@berland
Copy link
Copy Markdown
Collaborator

berland commented Aug 22, 2022

If not hard, it is beneficial to be compatible with both versions, allowing more flexibility in komodo deploy.

@asnyv asnyv merged commit 3be6c3c into equinor:master Aug 23, 2022
@asnyv asnyv deleted the opm202204 branch August 23, 2022 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants