Handle new IndexError message for empty decks in opm 2022.04#497
Merged
asnyv merged 2 commits intoequinor:masterfrom Aug 23, 2022
Merged
Handle new IndexError message for empty decks in opm 2022.04#497asnyv merged 2 commits intoequinor:masterfrom
asnyv merged 2 commits intoequinor:masterfrom
Conversation
|
Can one of the admins verify this patch? |
Codecov Report
@@ Coverage Diff @@
## master #497 +/- ##
==========================================
- Coverage 87.56% 87.55% -0.02%
==========================================
Files 49 49
Lines 7028 7030 +2
==========================================
+ Hits 6154 6155 +1
- Misses 874 875 +1
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
Collaborator
|
If not hard, it is beneficial to be compatible with both versions, allowing more flexibility in komodo deploy. |
berland
approved these changes
Aug 23, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Error message for requested deck keyword out of range apparently became less descriptive in
opm 2022.04Could alternatively keep the old message as well to support
2021.10, but find it ok to force2022.04to be able to catch it ifopmswitches back to the more descriptive message (have a feeling that it might not have been intended fromopm's)