Skip to content

Fix deprecations warning#534

Merged
alifbe merged 2 commits intoequinor:masterfrom
alifbe:fix-deprecations
Apr 27, 2023
Merged

Fix deprecations warning#534
alifbe merged 2 commits intoequinor:masterfrom
alifbe:fix-deprecations

Conversation

@alifbe
Copy link
Copy Markdown
Collaborator

@alifbe alifbe commented Apr 27, 2023

Resolve #510
Resolve #511

@ertomatic
Copy link
Copy Markdown

Can one of the admins verify this patch?

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #534 (ea8d439) into master (18d91b7) will decrease coverage by 0.01%.
The diff coverage is 100.00%.

❗ Current head ea8d439 differs from pull request most recent head 37e5d9d. Consider uploading reports for the commit 37e5d9d to get more accurate results

@@            Coverage Diff             @@
##           master     #534      +/-   ##
==========================================
- Coverage   86.17%   86.17%   -0.01%     
==========================================
  Files          49       49              
  Lines        7026     7025       -1     
==========================================
- Hits         6055     6054       -1     
  Misses        971      971              
Impacted Files Coverage Δ
src/subscript/check_swatinit/plotter.py 94.59% <100.00%> (ø)
...bscript/convert_grid_format/convert_grid_format.py 86.95% <100.00%> (-0.15%) ⬇️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alifbe alifbe requested review from berland, mferrera and rnyb April 27, 2023 12:58
Copy link
Copy Markdown
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alifbe alifbe merged commit e3c588d into equinor:master Apr 27, 2023
@alifbe alifbe deleted the fix-deprecations branch April 27, 2023 19:11
AudunSektnanNR pushed a commit to AudunSektnanNR/subscript-as that referenced this pull request Jun 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[checkswatinit] Solve deprecation warning [convert_grid_format] Solve deprecation warning

4 participants