Skip to content

pack_sim update#544

Merged
alifbe merged 2 commits intoequinor:masterfrom
alifbe:packsim-update
Jun 1, 2023
Merged

pack_sim update#544
alifbe merged 2 commits intoequinor:masterfrom
alifbe:packsim-update

Conversation

@alifbe
Copy link
Copy Markdown
Collaborator

@alifbe alifbe commented May 30, 2023

Resolve issue #538

@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #544 (737d9a1) into master (87a3dde) will increase coverage by 0.00%.
The diff coverage is 100.00%.

❗ Current head 737d9a1 differs from pull request most recent head 8c4f3a2. Consider uploading reports for the commit 8c4f3a2 to get more accurate results

@@           Coverage Diff           @@
##           master     #544   +/-   ##
=======================================
  Coverage   86.17%   86.17%           
=======================================
  Files          49       49           
  Lines        7025     7026    +1     
=======================================
+ Hits         6054     6055    +1     
  Misses        971      971           
Impacted Files Coverage Δ
src/subscript/pack_sim/pack_sim.py 89.32% <100.00%> (+0.04%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alifbe alifbe changed the title Packsim update pack_sim update May 31, 2023
@alifbe alifbe requested review from berland and rnyb May 31, 2023 07:23
Copy link
Copy Markdown
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alifbe alifbe merged commit d072f09 into equinor:master Jun 1, 2023
@alifbe alifbe deleted the packsim-update branch June 1, 2023 06:39
AudunSektnanNR pushed a commit to AudunSektnanNR/subscript-as that referenced this pull request Jun 20, 2023
…ywords (equinor#544)

* Fix bug with inline comment after section keyword
* Add inline comment to Reek Eclipse case
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants