Conversation
8a179d8 to
77b0485
Compare
alifbe
approved these changes
Jun 19, 2023
Collaborator
alifbe
left a comment
There was a problem hiding this comment.
LGTM 👍
I did a search for master in subscript repo and found this:
subscript/.pre-commit-config.yaml
Line 6 in e5e3f72
77b0485 to
64ccd9a
Compare
Collaborator
Author
|
Nice catch. I fixed it, although the branch protection rules should prevent commits to the default branch from getting upstream anyway so that hook is probably not needed. |
Codecov Report
@@ Coverage Diff @@
## main #551 +/- ##
=======================================
Coverage 86.20% 86.20%
=======================================
Files 49 49
Lines 7037 7037
=======================================
Hits 6066 6066
Misses 971 971 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.