Skip to content

Fix issue with eclrun cannot find Eclipse version during testing#569

Merged
alifbe merged 2 commits intoequinor:mainfrom
alifbe:fix-runeclipse-auto-version
Jun 28, 2023
Merged

Fix issue with eclrun cannot find Eclipse version during testing#569
alifbe merged 2 commits intoequinor:mainfrom
alifbe:fix-runeclipse-auto-version

Conversation

@alifbe
Copy link
Copy Markdown
Collaborator

@alifbe alifbe commented Jun 28, 2023

eclrun cannot find the latest version string during testing. This PR will use full path for eclrun

In the case that it failed to retrieve correct version, it will use 2023.1 as default version.

@alifbe alifbe requested review from berland, mferrera and rnyb June 28, 2023 09:03
Copy link
Copy Markdown
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me. Could revert cfe12bc with this change as well, and a similar change should probably be made to eclmanual too

@alifbe alifbe merged commit 87d60b2 into equinor:main Jun 28, 2023
@alifbe alifbe deleted the fix-runeclipse-auto-version branch June 28, 2023 21:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants