Create test files in temporary directories

[mferrera]

A few tests left test files in the root directory after a test run. This could cause race conditions in some cases with pytest-xdist and tests should not leave junk files in the root directory at any rate.

Resolves #563

[alifbe]

@mferrera Nice.....I did a quick search and found a few other places as well which are not typically run in the local setup, but I think is run within komodo testing. Do you think it's worth to update as well?

subscript/tests/test_ofmvol2csv.py

Line 513 in e4cba62

Path("FOOBAR.DATA").write_text("--Empty", encoding="utf8")

subscript/tests/test_check_swatinit_simulators.py

Line 57 in e4cba62

Path("FOO.DATA").write_text(str(resmodel), encoding="utf8")

[mferrera]

Good catch! The ones you highlighted are actually okay -- they use a fixture that changes dir for them (former case) or call the simulator function after changing dir in the test function (latter case). But I found a few cases where the dir change didn't happen or otherwise left files around. I don't seem to find any more files in the root dir when run with simulators as well now.

[alifbe]

Good catch! The ones you highlighted are actually okay -- they use a fixture that changes dir for them (former case) or call the simulator function after changing dir in the test function (latter case). But I found a few cases where the dir change didn't happen or otherwise left files around. I don't seem to find any more files in the root dir when run with simulators as well now.

Good to know 😄

[alifbe]

LGTM 👍