Add FORWARD MODEL and workflow job for params2csv#581
Merged
alifbe merged 3 commits intoequinor:mainfrom Jul 21, 2023
alifbe:param2csv-glob
Merged
Add FORWARD MODEL and workflow job for params2csv#581alifbe merged 3 commits intoequinor:mainfrom alifbe:param2csv-glob
alifbe merged 3 commits intoequinor:mainfrom
alifbe:param2csv-glob
Conversation
Collaborator
alifbe
commented
Jul 21, 2023
- Add glob to parameterfile argument (needed so that it works from within ERT)
- Add forward model PARAMS2CSV
- Add workflow job PARAMS2CSV
Codecov Report
@@ Coverage Diff @@
## main #581 +/- ##
==========================================
+ Coverage 84.65% 84.68% +0.03%
==========================================
Files 52 52
Lines 7466 7494 +28
==========================================
+ Hits 6320 6346 +26
- Misses 1146 1148 +2
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mferrera
approved these changes
Jul 21, 2023
Collaborator
mferrera
left a comment
There was a problem hiding this comment.
Looks great! Please consider the comments and remember to squash or rebase before merging 😄
mferrera
approved these changes
Jul 21, 2023
Collaborator
mferrera
left a comment
There was a problem hiding this comment.
Thanks for considering the comments! Just some quick follow-ups
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.