Skip to content

Add FORWARD MODEL and workflow job for params2csv#581

Merged
alifbe merged 3 commits intoequinor:mainfrom
alifbe:param2csv-glob
Jul 21, 2023
Merged

Add FORWARD MODEL and workflow job for params2csv#581
alifbe merged 3 commits intoequinor:mainfrom
alifbe:param2csv-glob

Conversation

@alifbe
Copy link
Copy Markdown
Collaborator

@alifbe alifbe commented Jul 21, 2023

  • Add glob to parameterfile argument (needed so that it works from within ERT)
  • Add forward model PARAMS2CSV
  • Add workflow job PARAMS2CSV

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jul 21, 2023

Codecov Report

Merging #581 (d26d54d) into main (6b443b8) will increase coverage by 0.03%.
The diff coverage is 84.44%.

❗ Current head d26d54d differs from pull request most recent head d03f61c. Consider uploading reports for the commit d03f61c to get more accurate results

@@            Coverage Diff             @@
##             main     #581      +/-   ##
==========================================
+ Coverage   84.65%   84.68%   +0.03%     
==========================================
  Files          52       52              
  Lines        7466     7494      +28     
==========================================
+ Hits         6320     6346      +26     
- Misses       1146     1148       +2     
Impacted Files Coverage Δ
src/subscript/eclcompress/allowlist.py 100.00% <ø> (ø)
src/subscript/co2_containment/co2_containment.py 43.58% <40.00%> (-0.48%) ⬇️
src/subscript/params2csv/params2csv.py 91.95% <89.18%> (+0.15%) ⬆️
src/subscript/eclcompress/eclcompress.py 94.84% <100.00%> (+0.08%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

Copy link
Copy Markdown
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Please consider the comments and remember to squash or rebase before merging 😄

Comment thread src/subscript/params2csv/params2csv.py Outdated
Comment thread src/subscript/params2csv/params2csv.py Outdated
Comment thread src/subscript/params2csv/params2csv.py
Comment thread src/subscript/params2csv/params2csv.py Outdated
Copy link
Copy Markdown
Collaborator

@mferrera mferrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for considering the comments! Just some quick follow-ups

Comment thread src/subscript/config_jobs/PARAMS2CSV Outdated
Comment thread src/subscript/params2csv/params2csv.py Outdated
@alifbe alifbe merged commit 29e2154 into equinor:main Jul 21, 2023
@alifbe alifbe deleted the param2csv-glob branch July 21, 2023 09:03
@mferrera mferrera mentioned this pull request Jul 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants