Skip to content

merge_rft_ertobs: validate OBSDIR input #616

Merged
alifbe merged 2 commits intoequinor:mainfrom
alifbe:merge_rft_ertobs-validate-obsdir
Oct 11, 2023
Merged

merge_rft_ertobs: validate OBSDIR input #616
alifbe merged 2 commits intoequinor:mainfrom
alifbe:merge_rft_ertobs-validate-obsdir

Conversation

@alifbe
Copy link
Collaborator

@alifbe alifbe commented Oct 11, 2023

Ensure that OBSDIR exist and trigger exception otherwise.

Solve #559

@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023

Codecov Report

Merging #616 (46a9988) into main (de57617) will increase coverage by 0.00%.
Report is 2 commits behind head on main.
The diff coverage is 100.00%.

❗ Current head 46a9988 differs from pull request most recent head 46bcb37. Consider uploading reports for the commit 46bcb37 to get more accurate results

@@           Coverage Diff           @@
##             main     #616   +/-   ##
=======================================
  Coverage   84.72%   84.72%           
=======================================
  Files          52       52           
  Lines        7507     7510    +3     
=======================================
+ Hits         6360     6363    +3     
  Misses       1147     1147           
Files Coverage Δ
src/subscript/eclcompress/allowlist.py 100.00% <ø> (ø)
src/subscript/merge_rft_ertobs/merge_rft_ertobs.py 94.59% <100.00%> (+0.22%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@alifbe alifbe requested a review from rnyb October 11, 2023 07:06
Copy link
Collaborator

@rnyb rnyb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alifbe alifbe merged commit 1a2e313 into equinor:main Oct 11, 2023
@alifbe alifbe deleted the merge_rft_ertobs-validate-obsdir branch October 11, 2023 12:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants