Skip to content

Conversation

@larsevj
Copy link
Collaborator

@larsevj larsevj commented Oct 3, 2025

Resolves #815

@larsevj larsevj requested a review from Copilot October 3, 2025 11:02
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR fixes several code quality issues in the prtvol2csv module to resolve issue #815. The changes focus on removing unused variables, improving variable usage patterns, and cleaning up linting configurations.

  • Removes unused variables and improves variable initialization patterns
  • Updates noqa comment specificity and removes redundant string conversions
  • Completely removes the .pylintrc configuration file

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/subscript/prtvol2csv/prtvol2csv.py Removes unused variables, improves variable initialization, and cleans up code formatting
.pylintrc Removes entire pylint configuration file
Comments suppressed due to low confidence (2)

src/subscript/prtvol2csv/prtvol2csv.py:1

  • The variable initial_date_found is being removed but it's still used in the conditional check on line 231. This will cause a NameError at runtime.
"""Extract volumes from Eclipse PRT files, augmenting with region and zone

src/subscript/prtvol2csv/prtvol2csv.py:1

  • The variable initial_date_found is being removed but it's still used in the conditional check on line 231. This will cause a NameError at runtime.
"""Extract volumes from Eclipse PRT files, augmenting with region and zone

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

@codecov-commenter
Copy link

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.65%. Comparing base (edb0ac8) to head (244d0f3).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #816      +/-   ##
==========================================
- Coverage   79.65%   79.65%   -0.01%     
==========================================
  Files          49       49              
  Lines        7511     7510       -1     
==========================================
- Hits         5983     5982       -1     
  Misses       1528     1528              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@larsevj larsevj requested a review from berland October 3, 2025 13:22
@larsevj larsevj merged commit 9c2790a into main Oct 6, 2025
4 checks passed
@larsevj larsevj deleted the fixup_prtvol2csv branch October 6, 2025 07:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

UnboundLocalError: cannot access local variable 'initial_date_found' where it is not associated with a value

4 participants