Skip to content

Improve message for user when falling back to device-code login #199

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
roywilly merged 4 commits into from
Apr 19, 2024
Merged

Improve message for user when falling back to device-code login #199

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
ed3c673
Improve error message for user when falling back to device-code login
roywilly Apr 16, 2024
5d85f7f
Improve wording on login msg
roywilly Apr 16, 2024
b7cab00
Change wording for fallback to devicecode login
roywilly Apr 16, 2024
62ec534
Remove message as it is printed every time, not only when token is ou…
roywilly Apr 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 1 addition & 6 deletions src/sumo/wrapper/_auth_provider.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -207,7 +207,7 @@ def login(self):
print(
"\n\n \033[31m NOTE! \033[0m"
+ " Please login to Equinor Azure to enable Sumo access: "
+ "we opened a login web-page for you in your browser."
+ "we are opening a login web-page for you in your browser."
+ "\nYou should complete your login within "
+ str(self._login_timeout_minutes)
+ " minutes, "
Expand Down Expand Up @@ -422,11 +422,6 @@ def get_auth_provider(
Path(lockfile_path).resolve()
).__contains__(platform.node()):
# https://github.com/equinor/sumo-wrapper-python/issues/193
print(
"Chromium lockfile points to another host, "
f"you should delete {lockfile_path}. "
"Falling back to device-code login now"
)
return AuthProviderDeviceCode(client_id, authority, resource_id)
# ELSE
return AuthProviderInteractive(client_id, authority, resource_id)