docs/adr: 0004 — glue-review v2 fix-pack architecture (closes #103)#104
Merged
docs/adr: 0004 — glue-review v2 fix-pack architecture (closes #103)#104
Conversation
Lock in the v2 architecture for agents/glue-review before any code moves: emit a single .glue-review-fixes.json artifact synthesized from multiple free models (DeepSeek-R1 + Qwen3 Coder + Kimi K2; synthesizer = DeepSeek-R1), drop the inline-comment / sticky-markdown / PR Reviews API surface entirely, and ship as a hard v2.0.0 with @v1 pinning for existing users. The ADR documents: - Fix-pack JSON schema (version 1) with concrete example and per-field semantics. Single source of truth — downstream tooling integrates against this contract. - Multi-model orchestration: parallel fan-out, drop-on-failure (HTTP 429 / 5xx), one-attempt-each, synthesizer waits for all primaries. - Synthesizer policy: drop fixes flagged by only one model. Schema retains models_flagged + dropped_singletons so downstream consumers can re-tune. - Synthesizer prompt skeleton (reproducible). - Surface deletions: parse.go, validate.go, pathspec_test.go, failover.go, v1+v2 markdown prompts, sticky-markdown step, PR Reviews API call. - Surface kept: tools.go, blocklist.go, fixture_test.go (adapted). - GitHub Action shape: artifact + job summary, no PR comments. - Migration plan: @v1 stays pinned, @v2 floats forward, MIGRATION.md in agent dir. Implementation is filed separately as a big-bang PR. Rationale for not splitting documented at the bottom of the ADR. Closes #103 Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Lock in the v2 architecture for
agents/glue-reviewbefore any code moves. The pivot:.glue-review-fixes.jsonartifact. No inline comments, no sticky markdown, no PR Reviews API.models_flagged+dropped_singletonsso downstream consumers can re-tune later.v2.0.0.@v1floating tag stays pinned to v1.1.0 for existing users; new repos opt into@v2.The ADR includes the concrete schema, the synthesizer prompt skeleton, the file-by-file deletion list (
parse.go,validate.go,pathspec_test.go,failover.go, v1/v2 markdown prompts, sticky-markdown step), and the migration plan.Implementation is intentionally not in this PR. It will land as a single big-bang PR; rationale for not splitting is documented at the end of the ADR.
Closes #103
Test plan
🤖 Generated with Claude Code