Skip to content

fix: use onlyEntryPoint for executeUserOp #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 9, 2024
Merged

fix: use onlyEntryPoint for executeUserOp #24

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2272b03
fix: use onlyEntryPoint for executeUserOp
leekt Mar 24, 2024
71ecbbf
Merge branch 'main' into fix/executeUserOp_modifier
kopy-kat Apr 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/MSAAdvanced.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -149,7 +149,7 @@ contract MSAAdvanced is IMSA, ExecutionHelper, ModuleManager, HookManager {
)
external
payable
onlyEntryPointOrSelf
onlyEntryPoint
{
bytes calldata callData = userOp.callData[4:];
(bool success,) = address(this).delegatecall(callData);
Expand Down
2 changes: 1 addition & 1 deletion src/MSABasic.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,7 @@ contract MSABasic is IMSA, ExecutionHelper, ModuleManager {
)
external
payable
onlyEntryPointOrSelf
onlyEntryPoint
{
bytes calldata callData = userOp.callData[4:];
(bool success,) = address(this).delegatecall(callData);
Expand Down
1 change: 1 addition & 0 deletions src/core/AccountBase.sol
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ contract AccountBase {
/////////////////////////////////////////////////////
// Access Control
////////////////////////////////////////////////////

modifier onlyEntryPointOrSelf() virtual {
if (!(msg.sender == entryPoint() || msg.sender == address(this))) {
revert AccountAccessUnauthorized();
Expand Down